Repository navigation
CI Pipeline fails because of a lost package #112
Description
The package in question is this one:
Microsoft.VisualStudio.CodingConventions
I was looking into creating a new pipe for a GTK3 upgrade, when I noticed all pipes were failing
because nuget couldn't find a specific version of that package. I'm not sure why, I can't find it anywhere
either. but locally it seemed that nuget has an older version available: 1.1.20180503.2
Ideally, this old package should be factored out and replaced by something newer, so maybe it's smth
to put on the roadmap.
Reacted by Precise
Activity
Gzushgshsh commentedon Jun 1, 2023
Is it possible to compile at the moment? The CI Pipeline is failing.
dotdevelop-make.log
In the build log I sent above, it shows this error with one package over and over again
NU1102: Unable to find package Microsoft.VisualStudio.CodingConventions with version (>= 1.1.20191022.5)
vanackerglenn commentedon Jun 1, 2023
@lucas-04 unfortunately, no.
I have a working version on my own fork, but am reluctant to merge that at the moment
because it is a preparation of porting dotDevelop to GTK3.
But doing that is something that I can't do alone, so I'm afraid more work is needed before
I can create a pull request.
malix0 commentedon Jun 15, 2023
Hi, I check my VisualStudio 2022 installation and I found Microsoft.VisualStudio.CodingConventions.dll version 1.1.2301.171 this dll is really small.
IMHO according to this article Visual Studio IntelliCode now infers coding conventions for consistent code looks Microsoft.VisualStudio.CodingConventions is just a wrapper around IntelliCode?
vanackerglenn commentedon Jun 15, 2023
@malix0 even though it's possible that that library is distributed with visual studio as a dll, it's unwise to include it in dotdevelop for several reasons.
It's a dll, we don't have a clear view on it's own dependencies, and we would need to write a wrapper to import it. The aim is to move away from windows specific libraries and the mono/net framework dependency. So, while It's now downgraded to a previous version, it should be replaced in the future.
In my personal opinion, we should also not strive to have coding conventions dictated by microsoft, even if I do follow those conventions myself.
MakiWolf commentedon Jun 15, 2023
For interesting. Does this dll exist on windows or mac or on both operating systems? Because Visual Studio for Mac was build on top of MonoDevelop a long time ago.
lextm commentedon Jun 17, 2023
No, it doesn't. Strictly such assemblies are part of VS, so MonoDevelop usually cannot depend on them.
MakiWolf commentedon Jun 20, 2023
@gluckez I totally agree that this package should be replaced by something else or removed. It is still unclear how long the old version will be avilable to download on nuget and source code seems to be not avilable for building this package self. So this should have priority on roadmap.
MakiWolf commentedon Jun 20, 2023
The package is often included in code, so it will be difficult to replace or remove. Hopefully we find a solution for that problem.
Search results for Microsoft.VisualStudio.CodingConventions
https://github.com/search?q=repo%3Adotdevelop%2Fdotdevelop%20Microsoft.VisualStudio.CodingConventions&type=code
Search results for ICodingConventionContext
https://github.com/search?q=repo%3Adotdevelop%2Fdotdevelop+ICodingConventionContext&type=code