Repository navigation
Commit d5dd4d2
Type web detection detectors as expressions in the schema (#6292)
* Type web detection detectors as expressions in the schema
`match` takes an expression, and `actions` takes an action object or
a sequence of expressions with `define`, `if` and payloads. The
`{ any | all | none }` form of `element` and `text` stays valid, so
every shipped `match` validates unchanged. A detector needs `match`,
`actions` or both.
Actions take no `state`. The config drops the 42 `"state": "enabled"`
entries on `fireEvent` and `breakageReportData`, which is the default
shipped clients apply.
A JSON patch operation takes `value` only for add, replace and test,
and `from` for move and copy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Require actions on web detection detectors, and keep rules out of the schema
A detector needs `actions`. The 9 detectors without them get
`{ "breakageReportData": {} }`, the action shipped clients already
apply by default. The 7 patches that added `actions` to the video and
login detectors add `actions/fireEvent` instead, beside it. Every
client resolves the same detectors as before.
The schema holds types only. The CI checks and the web detection docs
state the name and key patterns, placement and meaning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Patch both actions into the video and login detectors
The 7 patches that add `actions` to the video and login detectors keep
their path, and add `breakageReportData` beside `fireEvent`. The
patched detectors are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 2e5a8b7 commit d5dd4d2
5 files changed
Lines changed: 292 additions & 60 deletions
File tree
- features
- schema
- features
- tests
0 commit comments