⚡ Sangsakala Proxy 🏠 Home
Skip to content

Implement generateDatabase = true flag in DuckDBProvider.java #1173

Open

Description

@Vedant1parekh

In the DuckDBProvide.java ,i have observed that it has not implemented the generateDatabase flag which must be part of DuckDBOptions.java.
I figure out this thing while closely debugging SQLite3Provider.java.

what i will change

  1. Implement the flag in options file.
  2. Will add logic to create new DB and also to created multiple tables similar to SQLite3Provider.java.
  3. Also one TODO is there will try to fix it.
if (globalState.getSchema().getDatabaseTables().isEmpty()) {
            throw new IgnoreMeException(); // TODO
        }

Let me know if you need any clarification....

Activity

  1. cking100 commented on Mar 21, 2025

    @cking100

    @Vedant1parekh so we need to implement the flag in duckdb the same way its done in sqlite?

  2. Vedant1parekh commented on Mar 21, 2025

    @Vedant1parekh
    Author

    @cking100 as per my understanding till now.. we have to do same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions