⚡ Sangsakala Proxy 🏠 Home
Skip to content

Add quick and full check profiles - #142

Merged
Kevinjohn merged 1 commit into
mainfrom
std/l1-sd-03
Nov 3, 2026
Merged

Kevinjohn merged 1 commit into
mainfrom
std/l1-sd-03

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Closes #120

Change

  • Add pnpm check with the specified quick and --full script profiles.
  • Run test:built-exports after build in check:changed when a public export input changes, including src/receipts.ts.
  • Document the profile command and verify script/workflow coverage in focused specs.

The copied profile coverage spec needed one SD-specific adaptation: docs.yml runs the dedicated site docs:build, which the issue's exact quick/full profiles omit. The spec exempts only that workflow/script pair; it still rejects any other uncovered workflow script. No listed profile script was added or dropped.

Verification

Node 24.21.0 and pnpm 11.23.0: pnpm lint, pnpm typecheck, pnpm build, pnpm docs:check, pnpm check, pnpm test:pg (339 passed, 3 skipped), pnpm test:built-exports (5 passed), and pnpm test:consumer (54 passed) passed. The quick profile inside pnpm check ran the SQLite suite (332 passed, 10 skipped), built the package, then passed the built-export suite (5 passed). Focused profile/planner specs passed 66/66. Removing the new planner selection or the covered lint script made the respective tests fail, then restoring them passed.

Done-when commands and output:

$ pnpm check
[check] PASS

$ pnpm check:changed --static origin/main
format: pass
lint: pass
typecheck: pass
build: pass
built exports: pass
tests: pass (87 tests run)
test suite: skip (--static)
consumer: skip (--static)
docs: pass

For the check:changed proof, src/receipts.ts was temporarily changed in the worktree and restored after the command; that file is not part of this PR. The full profile's script list is asserted by the copied profile spec; the quick profile was exercised end to end here.

Merge order

#140 → #141 → #144 → #145, #142 → #143

Merge predecessor for this PR: none

Conflicts: none. Each PR test-merges cleanly into its base and into every other open PR, and the combined tree in the order above passes pnpm check:changed origin/main.

@Kevinjohn

Copy link
Copy Markdown
Owner Author

Review at aa6ef8a found no P1 or P2 issues, so no commits were added.

Verified against the tree:

  • BUILT_EXPORTS in bin/check_changed_plan.ts selects the built-export gate for index.ts, src/types/, src/receipts.ts, src/mixin.ts and tests/declarations.spec.ts. Build runs before the gate, and a failed build skips it with a line saying so.
  • bin/check_profiles.ts lists the quick and full steps. tests/tooling/check_profiles.spec.ts checks that each step names an existing script and that each CI workflow script is covered.
  • Mutation checks: removing the built-export selection line fails 5 tests in tests/tooling/check_changed_plan.spec.ts (57 passed, 5 failed). Removing the lint step from the quick profile fails tests/tooling/check_profiles.spec.ts (3 passed, 1 failed). Both files were restored afterwards.

Checks:

Merge predecessor: none (base main).

@Kevinjohn Kevinjohn added polish-done PR polish state and removed polish-in-progress PR polish state labels Nov 3, 2026
@Kevinjohn Kevinjohn added the merge-in-progress A merge run is landing this PR label Nov 3, 2026
@Kevinjohn
Kevinjohn merged commit 9920b0a into main Nov 3, 2026
8 checks passed
@Kevinjohn
Kevinjohn deleted the std/l1-sd-03 branch November 3, 2026 18:50
@Kevinjohn Kevinjohn removed the merge-in-progress A merge run is landing this PR label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polish-done PR polish state

Projects

None yet

Development

Successfully merging this pull request may close these issues.

L1-SD-03 L1 pnpm check with quick and full profiles; check:changed runs the built-exports gate

1 participant