Repository navigation
Add quick and full check profiles - #142
Merged
Merged
Conversation
Owner
Author
|
Review at aa6ef8a found no P1 or P2 issues, so no commits were added. Verified against the tree:
Checks:
Merge predecessor: none (base |
This was referenced Nov 3, 2026
This was referenced Nov 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
Change
pnpm checkwith the specified quick and--fullscript profiles.test:built-exportsafter build incheck:changedwhen a public export input changes, includingsrc/receipts.ts.The copied profile coverage spec needed one SD-specific adaptation:
docs.ymlruns the dedicated sitedocs:build, which the issue's exact quick/full profiles omit. The spec exempts only that workflow/script pair; it still rejects any other uncovered workflow script. No listed profile script was added or dropped.Verification
Node 24.21.0 and pnpm 11.23.0:
pnpm lint,pnpm typecheck,pnpm build,pnpm docs:check,pnpm check,pnpm test:pg(339 passed, 3 skipped),pnpm test:built-exports(5 passed), andpnpm test:consumer(54 passed) passed. The quick profile insidepnpm checkran the SQLite suite (332 passed, 10 skipped), built the package, then passed the built-export suite (5 passed). Focused profile/planner specs passed 66/66. Removing the new planner selection or the coveredlintscript made the respective tests fail, then restoring them passed.Done-when commands and output:
For the
check:changedproof,src/receipts.tswas temporarily changed in the worktree and restored after the command; that file is not part of this PR. The full profile's script list is asserted by the copied profile spec; the quick profile was exercised end to end here.Merge order
#140 → #141 → #144 → #145, #142 → #143
Merge predecessor for this PR: none
Conflicts: none. Each PR test-merges cleanly into its base and into every other open PR, and the combined tree in the order above passes
pnpm check:changed origin/main.