Repository navigation
Overcooked! All You Can Eat: profile, Unity shader keys and a Frame rate choice (patches 0054–0056) - #372
Overcooked! All You Can Eat: profile, Unity shader keys and a Frame rate choice (patches 0054–0056)#372TeeJayBaker wants to merge 2 commits into
Conversation
…054, 0055) 0054 adds three optional profile keys to shader_split.py (unity_tier, unity_skip_keywords, unity_skip_passes) that leave out the Unity programs a player never draws; 0055 is the game's profile, which uses them to cut its split from 520,394 shaders to 45,221, and plays at 60 fps on the Mac. Both are forwarded as seedds/nxnative#836. The games table and the READMEs count 95 profiles. Refs LNPANDY#369.
… games (Overcooked, Monster Train 2) Forwarded as part of seedds/nxnative#836. Refs LNPANDY#369.
|
Thanks for the profile. The size of the diff (78k lines) looks like the shader tables and screenshots, is that right? It is in v1.1.3. Engine changes go to seedds/nxnative first, as |
|
Yes, nearly all of it is patch 0055's generated tables: The upstream PR is seedds/nxnative#836, already in the patch headers. |
|
Thanks for the explanation of the size: generated tables and one binary screenshot, small hand-written parts. That is fine. The engine moves to a newer pin for v1.0.2, so the three patches may need a refresh afterwards. I will write here when the bump is in |
Fix or feature
What and why
A profile for Overcooked! All You Can Eat (
0100F28011892000, update 1.0.11 = v720896, Unity 2019.4.11f1), carried as three patches until seedds/nxnative#836 lands. Refs #369.0054: three optional profile keys inshader_split.py(unity_tier,unity_skip_keywords,unity_skip_passes) that leave out the Unity programs the player never draws: other hardware tiers, keyword variants the game data never enables, and the editor-only Meta pass. Without the keys nothing changes.0055: the game's profile. With the keys its split goes from 520,394 shaders (2.3 GB package) to 45,221 (198 MB). It also setsdepth_mode zeroandpresent_interval display(60 fps). The game note has the evidence for each cut and its limits.0056: a launcher Frame rate choice (30 / 60 fps,DM_PRESENT_INTERVAL) for a profile withpresent_interval displayand nofps_target: Overcooked and Monster Train 2, which had no 30 fps choice outside an env file.GAMES.md,GAMES.zh-CN.mdand both READMEs get the row and count 95 profiles. TheGAMES.mdgallery is not regenerated: its images link to upstream's pinned commit, which does not have this screenshot yet.Checked
python3 tools/engine.py check(37 patches apply cleanly to c5fe6b5dbcb2),tools/tests. Inengine/:test_unity_tier.py,test_launcher_settings.py,test_settings.py,test_game_profile.py,test_pso_offline.py, lint with 0 new findings.test_docs.pyfails only ontest_gallery_is_current, as on main without these patches.Screenshots
None, no visible change.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is open