Repository navigation
Conversation
…ute selectors
- `[attr]` no longer matches a boolean property that is false. Every view
has `hidden` (false by default), so `[hidden] { display: none }` from
a CSS reset (Tailwind's preflight, Bootstrap's Reboot) hid the whole
app. A boolean is now present only while true, like an HTML boolean
attribute; `[hidden=false]` still compares by value.
- `[class*=x]`, `[class^=x]`, `[class$=x]`, `[class=x]` and `[class|=x]`
were all turned into the class selector `.x`, ignoring the operator.
Only `.x` and `[class~=x]` are class matches now; the other operators
match the class attribute's text.
|
View your CI Pipeline Execution ↗ for commit aab87c4
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
[attr]matches any non-null value. Every view hashidden,falseby default, so[hidden] { display: none }from a CSS reset (Tailwind's preflight, Bootstrap's Reboot) hides the whole app.classis turned into a class selector, whatever its operator:[class*='btn-'],[class^='col']and[class='a b']all behave like.btn-,.col,.a b.What is the new behavior?
[attr]only while it istrue, like an HTML boolean attribute.[hidden=false]still compares by value..xand[class~=x]are class matches. The other operators match theclassattribute's text.Tests:
css-selector.spec.ts(4).Verified with all of these core PRs merged together (#11527–#11537):
apps/automatedpasses on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependentIMAGE-CACHE.test_ImageCache_ValidUrltimeout, which also passes on reruns).