⚡ Sangsakala Proxy 🏠 Home
Skip to content

fix(core): a not media query negates the whole query - #11594

Open
NathanWalker wants to merge 1 commit into
mainfrom
fix/media-query-not
Open

NathanWalker wants to merge 1 commit into
mainfrom
fix/media-query-not

Conversation

@NathanWalker

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

matchQuery returns false early whenever a not query's media type matches, before looking at its features. So any not all and (...) or not screen and (...) query never matches:

  • not all and (min-width: 600) on a 400-wide screen is false (should be true). Tailwind v3 compiles its max-*: variants to this form.
  • not print and (min-width: 100) on a screen is false when the width matches, although the type alone already makes the inner query false.

The existing "should return false when theres a match on a not query" spec asserted the bug: it used orientation: landscape against (orientation: portrait), a non-match, and expected false.

What is the new behavior?

not negates the whole query, type and features together, as in Media Queries Level 4: the query is true when its type does not match or any of its features does not match.

Tests: the existing not spec now uses an actual match, plus new cases for a feature mismatch and a type mismatch (both failed before the change). The core unit suite passes.

Found while reviewing #11530 (range syntax), whose (width < 40rem) form is what Tailwind v4 uses instead. The two touch the same file and merge cleanly.

@nx-cloud

nx-cloud Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7cc1c4b

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 2m 52s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-29 17:51:42 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11594
npm i https://pkg.pr.new/@nativescript/vite@11594
npm i https://pkg.pr.new/@nativescript/webpack@11594

commit: 7cc1c4b

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant