Repository navigation
Stop enforcing invariant culture in build pipelines - #28260
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoOct 26, 2026
Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
Dongbo Wang (daxian-dbw) merged 2 commits into
Conversation
…o allow use non-invariant culture Set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT to false to avoid Archive module loading issue Cherry picked from !42308 ---- #### AI description (iteration 1) #### PR Classification Configuration change to fix a bug preventing use of non-invariant culture. #### PR Summary Sets `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` to `false` in pipeline variable templates to allow non-invariant culture usage. - `PowerShell-Coordinated_Packages-Variables.yml`: changed `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` value from `true` to `false`. - `PowerShell-Release-Variables.yml`: changed `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` value from `true` to `false`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
October 25, 2026 18:36
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Patrick Meinecke (SeeminglyScience)
approved these changes
Oct 25, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Linux pipeline validation is needed to confirm that removing the ICU workaround does not reintroduce BinSkim failures.
No open issues 🎉
What changed in this PR
Removes pipeline-wide invariant globalization settings so culture-dependent operations, including loading Microsoft.PowerShell.Archive, can use the build image’s default en-US culture.
Changes:
- Removes
DOTNET_SYSTEM_GLOBALIZATION_INVARIANTfrom both shared pipeline variable templates. - Removes the associated comments describing the Linux BinSkim ICU workaround.
| File | Description |
|---|---|
| .pipelines/templates/variables/PowerShell-Release-Variables.yml | Stops enforcing invariant globalization in release pipelines. |
| .pipelines/templates/variables/PowerShell-Coordinated_Packages-Variables.yml | Stops enforcing invariant globalization in coordinated packaging pipelines. |
Review effort: Balanced
Aditya Patwardhan (adityapatwardhan)
approved these changes
Oct 25, 2026
Dongbo Wang (daxian-dbw)
merged commit Oct 26, 2026
46f6096
into
PowerShell:master
38 of 39 checks passed
Member
Author
|
The equivalent of the changes was already in the 7.4/7.5/7.6 release branches. Now we only need to make sure this gets ported to 7.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
With the environment variable
DOTNET_SYSTEM_GLOBALIZATION_INVARIANTset to true, only invariant culture is allowed in the build pipelines. However, the default culture of the build image isen-US, and therefore that env var causes failure when loading theMicrosoft.PowerShell.Archivemodule because the module runsImport-LocalizedDatausing the default cultureen-US, which gets blocked.This PR stops enforcing invariant culture in build pipelines by removing those 2 env vars.