Repository navigation
Fix release automation test defects - #28285
Open
Justin Chung (jshigetomi) wants to merge 3 commits into
Open
Justin Chung (jshigetomi) wants to merge 3 commits into
Justin Chung (jshigetomi) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Set-Clipboard can still hang on Linux when a background clipboard owner retains redirected pipes, and the regression test can pass without establishing helper startup or verifying termination.
2 open issues
What changed in this PR
This PR addresses release-automation test defects and adds clipboard timeout handling to improve validation and diagnostics.
Changes:
- Update startup assembly and MSIX PATH expectations.
- Preserve module setup and import errors, and stop remoting setup after session-creation failures.
- Add clipboard helper timeout cleanup and a regression test.
| File | Description |
|---|---|
test/tools/Modules/HelpersRemoting/HelpersRemoting.psm1 |
Make remote-session creation errors terminating. |
test/powershell/Modules/Microsoft.PowerShell.Utility/Implicit.Remoting.Tests.ps1 |
Reject null sessions before remote setup. |
test/powershell/Modules/Microsoft.PowerShell.Management/Clipboard.Tests.ps1 |
Add clipboard helper timeout coverage. |
test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 |
Capture job failures, verbose output, paths, and hashes. |
test/powershell/Host/Startup.Tests.ps1 |
Fail only for unexpected loaded assemblies. |
test/powershell/Host/ConsoleHost.Tests.ps1 |
Derive expected MSIX PATH from package identity. |
test/powershell/engine/Module/ModulePath.Tests.ps1 |
Surface setup errors and normalize paths without requiring existence. |
src/Microsoft.PowerShell.Commands.Management/commands/management/Clipboard.cs |
Handle helper timeouts and read redirected output asynchronously. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Summary
Fixes six confirmed defects found while triaging the PowerShell 7.7.0-rc.1 release-automation test failures:
The unconfirmed macOS SSH exception-mapping failure is intentionally unchanged pending reproducible SSH/DNS evidence.
PR Context
The 7.7.0-rc.1 release-automation comparison reported 19 new failures. Several were false failures or setup/diagnostic defects that prevented the tests from validating product behavior. The clipboard failure also exposed a product bug where
Process.ExitCodewas read after a timed wait returnedfalse.Validation:
Import-Module .\tools\ci.psm1; Start-PSBuild -CI— Debug build passed; the optional Pester restore reported thatPSGallerywas unavailable.Import-Module .\tools\ci.psm1; Start-PSBuild -Configuration Release -NoPSModuleRestore— passed.falls back when the clipboard helper times out— passed, 1/1.pwsh updates PATH correctly even if PATH is not defined— passed, 1/1.Import-Module.Tests.ps1— both changed executable-manifest cases passed; 25 passed and one unrelated existing GAC expectation failed..ps1and.psm1files — passed.ModulePath.Tests.ps1and the affected implicit-remoting Describe were not run because this session is not elevated.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header