⚡ Sangsakala Proxy 🏠 Home
Skip to content

Preserve unpacked GenericAlias state during substitution - #9467

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-generic-alias-unpack-20261029
Oct 30, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:py315-generic-alias-unpack-20261029

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Preserve the unpacked (starred) flag when substituting parameters of a GenericAlias. CPython's ga_getitem copies this flag onto the newly created alias; RustPython was always resetting it to false.

For example, substituting into an unpacked *tuple[T] should retain the unpacked alias and its __unpacked__ value rather than returning an ordinary tuple[int] alias.

Verification

  • Scoped VM cargo check and Clippy passed.
  • A fresh CLI build in a dedicated target directory passed.
  • Six unchanged CPython tests passed on both CPython and the candidate: the four GenericAliasSubstitutionTests methods plus test_genericalias.BaseTest.test_unpack and test_iter_creates_starred_tuple. No skips or expected failures in this selection.
  • Eleven finite ordinary/unpacked/nested/variadic substitution cases produced identical full JSON transcripts on both interpreters, including representation, origin, arguments, parameters and unpacked state.
  • Normal commit hooks passed, including rustfmt, Ruff and cspell.

The full workspace/C-API suite and complete test_typing module were not run locally. This draft awaits normal CI for broader coverage.

Part of the Python 3.15 upgrade split from #8954. No new snippets or Rust tests of Python behavior are added.

Match CPython ga_getitem by retaining the starred flag when substituting generic alias parameters. Sync test_typing from the pinned CPython source with update_lib and retire the now-passing variadic substitution marker.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/typing.py
[x] test: cpython/Lib/test/test_typing.py
[x] test: cpython/Lib/test/test_type_aliases.py
[x] test: cpython/Lib/test/test_type_annotations.py
[x] test: cpython/Lib/test/test_type_params.py
[x] test: cpython/Lib/test/test_genericalias.py

dependencies:

  • typing

dependent tests: (22 tests)

  • typing: test_annotationlib test_builtin test_copy test_descr test_enum test_fractions test_free_threading test_funcattrs test_functools test_genericalias test_grammar test_inspect test_isinstance test_patma test_peg_generator test_pydoc test_pyrepl test_remote_pdb test_type_aliases test_type_params test_types test_typing

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:py315-generic-alias-unpack-20261029 (526bef0) with main (d24ca41)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@youknowone
youknowone marked this pull request as ready for review October 30, 2026 14:48
@youknowone
youknowone merged commit c84c82a into RustPython:main Oct 30, 2026
22 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T14:49:48.079756Z
We couldn’t complete this review. Comment @codex review to try again.
526bef0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants