Repository navigation
Fix math reduction conversion and numeric protocol handling - #9666
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Preserve dist materialization and coordinate conversion order, exact-type prod fast paths, and sumprod iterator errors and boolean compensation. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align math reduction protocol handling with CPython 3.15:
distpoints and check dimensions before converting coordinates; convert matching coordinates in p/q order and read tuple subclasses directly.prodfast paths to exact builtin types, preserving float subclass multiplication and empty-product results. Simplify the staged accumulator and enable its integer path for explicit integer starts.sumproditerator construction and exception order, including errors paired with exhaustion. Include bool weights in compensated float accumulation.Uses existing typed argument binding, sequence conversion, arithmetic, and pymath norm/compensation machinery. No tests, Python files, or workflows changed.
Source comparison
Compared against CPython revision d220409a13b77de7a6c30abe16ea90db01528edc:
Validation
-D warnings) for rustpython-vm, rustpython-host_env, and rustpython-stdlib with rustpython-stdlib/threading, locked/offline and one build job, against base 0b081b0.This does not claim full math parity. In particular, sumprod retains its existing O(n) buffered float-pair storage rather than implementing CPython’s streaming accumulator.
AI-assisted implementation and source comparison using OpenAI Codex (model version not exposed), directed by the maintainer.