Repository navigation
Share calendar time argument conversion - #9670
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Preserve numeric protocols, tuple callback order, and hidden timezone fields across time conversion APIs. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gmtime,localtime, andctime, preserving index precedence, callback exceptions, fractional rounding, and timestamp overflow handling.mktime,asctime, andstrftime. Read tuple storage directly and retainstruct_time's hidden timezone fields, including C-string prefixes for embedded NULs.mktimecan normalize fields, while preserving existing public Rust helper signatures through thin wrappers.Reference: CPython 3.15 calendar tuple conversion.
Validation
rustfmt --checkandgit diff --checkpass. Independent source review completed.cargo checkand strictcargo clippy -- -D warningscoverrustpython-vm,rustpython-host_env, andrustpython-stdlibwithrustpython-stdlib/threading(--locked --offline -j1).Malformed-tuple diagnostics remain generic rather than matching each function's wording exactly. Existing non-Unix calendar fallback limitations are not addressed. The patch changes no tests, snippets, or workflows.
AI assistance: implementation, CPython reference probes, overlap audit, and source review were performed with OpenAI Codex under the directing maintainer's instructions.