Repository navigation
Align resource and syslog argument conversion - #9672
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Reuse existing argument and string conversion machinery for Python 3.15 callback order, auditing, and Unix control widths. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setrlimitbefore converting limits.sys.argvwithout invoking module hooks, preserve basename object identity, and handle Unicode/NUL identifiers using shared string helpers.Reuses derived
FromArgs,OptionalArg, existing numeric conversion andPyStr::try_as_utf8; removes bespoke conversion code. Public host APIs remain unchanged. Two production files, 157 changed lines.Reference and validation
References: CPython 3.15.0 resource.c, syslogmodule.c, and generated syslog argument handling.
-D warnings) passed for explicitly selected rustpython-vm, rustpython-host_env and rustpython-stdlib with stdlib/threading, using locked/offline builds. A subsequent spelling-only local-variable rename passed normal commit hooks.The existing resource-count fallback and persistent Python ident retention difference remain outside this patch: the host retains the C string rather than CPython's original Python ident object. Out-of-range LOG_MASK/LOG_UPTO shifts are unchanged.
AI-assisted implementation, source review, and validation using OpenAI Codex (model version not exposed).