Repository navigation
Align Linux locale collation with Python 3.15 - #9674
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Use wide collation strings, retain surrogate code points, encode transform weights in Python 3.15 order, and preserve errno and allocation failures. AI-assisted implementation, source review, and validation using OpenAI Codex. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_locale.strcollandstrxfrmthrough wide-character collation, retaining lone surrogates and rejecting embedded NULs through a shared converter after normal argument binding.> 0x10000boundary; preserve individual surrogate weights and propagate libc errors separately from allocation failures.The current narrow UTF-8 route reverses comparisons in non-UTF-8 locales. In installed
sv_SE, comparingzwithäreturns positive through the current narrow call but negative through CPython's wide call. Reference probes found 24/100 ordering differences in each ofen_USandde_DE, and 36/100 insv_SE.Reference: CPython 3.15 collation implementation.
Validation
cargo checkfor host_env, vm and stdlib, withrustpython-stdlib/threading, locked/offline, one job.-D warnings).Native RustPython execution, full suites and other platforms were not run. No tests, standard-library Python files or workflows are changed. No >Unicode raw weights or invalid-UTF-8 narrow keys were observed; allocation-failure and concurrent-size-change branches were source-reviewed, not fault-injected.
AI assistance
Implementation, source review and validation were AI-assisted using OpenAI Codex (model version not exposed).