Repository navigation
Align in-memory I/O position controls - #9675
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Use typed seek parameters in conversion order, enforce signed BytesIO positions, and delay truncate index conversion until state validation. Recheck stream state after index callbacks without holding storage locks. Guard overflowing nonempty writes before allocation and remove obsolete conversion helpers. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BytesIO/StringIO.seek(pos, whence)arguments in order and keep BytesIO positions within the signed-size range, including negative relative seeks and overflow.Uses existing numeric conversion and buffer-resize guards, with no per-method
FuncArgsparser. Post-index closed/export rechecks are intentional Rust safety checks: CPython's truncate bodies check those conditions before conversion only.Reference: CPython 3.15.0 BytesIO, StringIO, and seek argument conversion.
Validation
git diff --checkpassed.AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, and independent source review; model version was not exposed.