⚡ Sangsakala Proxy 🏠 Home
Skip to content

Align deque comparison and insertion controls - #9678

Draft
youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:deque-comparison-controls-group-20261103
Draft

youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:deque-comparison-controls-group-20261103

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

  • Check deque mutation after each count comparison, before invoking any later comparator.
  • Reuse index search for containment while preserving successful-match, callback-exception and finalizer ordering.
  • Bind insertion indexes through the existing signed machine-width converter and remove the unused sequence-trait implementation.

Comparison references are released outside storage locks. Existing index range handling and remove behavior are preserved.

Reference: CPython 3.15.0 deque count, containment, index and insert.

Validation

  • Independent source review, formatting and whitespace checks passed.
  • Two independent runs reproduced 80 CPython 3.15 callback cases, with additional index-boundary, identity-shortcut, bounded-deque and comparison-result boolean-callback probes.
  • Fresh focused VM, host-env and stdlib check and strict Clippy with rustpython-stdlib/threading passed. Normal repository commit hooks passed.
  • RustPython runtime, full workspace/C-API suites, and cross-platform execution were not run. No test, Lib, workflow, or marker edits.

AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, and independent source review; model version was not exposed.

Share comparison and search helpers with callback-safe item release.
Check count mutation after every comparison while preserving successful
containment ordering. Use signed machine-width insertion indexes and
remove the unused sequence-trait implementation.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant