Repository navigation
Align partial construction and state controls - #9679
Draft
youknowdot wants to merge 3 commits into
Draft
youknowdot wants to merge 3 commits into
youknowdot wants to merge 3 commits into
Conversation
Preserve nested keyword ownership and lazy instance dictionaries, use native Placeholder identity, and share constructor argument binding. Validate restored state before callback conversion, retain instance dict identity, and copy stored keyword entries without rehashing keys. Assisted-by: OpenAI Codex:model version not exposed
PosArgs exposes its borrowed slice through AsRef rather than as_slice. Assisted-by: OpenAI Codex:model version not exposed
Avoid a redundant strong reference when constructing a nonnested partial. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalid state is rejected before mutation. Successful field replacement remains sequential, matching CPython rather than claiming transactional reentrant updates.
Reference: CPython 3.15.0 partial construction and state restoration.
Validation
rustpython-stdlib/threadingpassed. Normal repository commit hooks passed.AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, and independent source review; model version was not exposed.