Repository navigation
Align native signal controls and handler dispatch - #9683
Draft
youknowdot wants to merge 3 commits into
Draft
youknowdot wants to merge 3 commits into
youknowdot wants to merge 3 commits into
Conversation
Reuse the shared time and truth-value converters, preserve timer errno, and match native signal handler and wakeup-fd validation order and domains. Assisted-by: OpenAI Codex:model version not exposed
Retain the checked time_t conversion on narrower hosts and bind socket fields only on Windows. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Keep ignored and foreign native SIGINT handlers during initialization and release replaced Python handlers outside the table borrow. Share exact native disposition classification and pass the current complete frame to normal signal callback dispatch, retaining errors when a registered object ceases to be callable. No signal ownership, shutdown, or interrupt_main producer redesign is included. Existing expected-failure markers remain pending runtime tests. Assisted-by: OpenAI Codex:model version not exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align native signal controls and ordinary handler dispatch with CPython 3.15:
Reference: CPython 3.15.0 signal module and complete-frame selection.
Validation
cargo clippy --locked --offline -p rustpython-vm --all-targets --features threading -- -D warningspassed.cargo clippy --locked --offline -p rustpython-vm --all-targetspassed with the existing no-thread Arc warning at_ctypes/base.rs:2246.Scope
This does not redesign process-global signal ownership across independently embedded runtimes, signal teardown, interrupt_main's producer semantics, or missing-handler diagnostics. In particular, this does not resolve or retire the shutdown interrupt_main expected failure. Ordinary dispatch and startup changes add no new native signal-handler operations or cross-thread frame reads.
AI assistance: OpenAI Codex performed source comparison, implementation and independent source review; model version was not exposed.