Repository navigation
Align TypeAliasType constructor binding and validation - #9687
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Reuse shared raw argument binding, validate native type parameters before reading defaults, and preserve callback exceptions and WTF-8 diagnostics. Normalize empty parameter tuples while retaining inputs through allocation, and derive caller module metadata from the existing function-frame API. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference: CPython 3.15.0 TypeAliasType construction and type-parameter validation and generated Clinic wrappers.
Validation
cargo check --locked --offline -j1 -p rustpython-host_env -p rustpython-vm -p rustpython-stdlib --features rustpython-stdlib/threadingpassed.-- -D warningspassed. This is a focused threading-enabled subset of CI, not the full workspace/all-targets suite.Shared-binder mixed-invalid error precedence and wording remain different from Clinic in some combinations. This change adds no bespoke parser or VM frame architecture changes, and is independent of the TypeVar constructor group.
AI assistance: OpenAI Codex performed source comparison, implementation, reference probes and independent source review; model version was not exposed.