Repository navigation
Align shutdown flush and unraisable reporting with CPython - #9690
Draft
youknowone wants to merge 1 commit into
Draft
youknowone wants to merge 1 commit into
youknowone wants to merge 1 commit into
Conversation
Share the fallible default writer, retain the selected output stream across callbacks, and keep user hooks available during finalization. Flush after exit callbacks and propagate either stream failure to exit status 120. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align shutdown stream failures and unraisable exception reporting with CPython 3.15, using one shared fallible writer instead of separate default-hook and VM fallback implementations.
The remaining
test_cmd_line.test_stdout_flush_at_shutdownexpected failure motivates this group. Its marker is unchanged; this PR does not claim the test passes or full shutdown parity. No Lib files or tests are edited, and no thread, GC, or signal algorithm is replaced.Reference
Compared against CPython 3.15 commit
d220409a13b77de7a6c30abe16ea90db01528edc:Validation
git diff --checkpassed.cargo clippy --locked --offline -p rustpython-vm --all-targets --features threading -- -D warningspassed.cargo clippy --locked --offline -p rustpython-vm --all-targetspassed with the existing no-threadArc<BufferWrite>warning at_ctypes/base.rs:2246.AI assistance: OpenAI Codex (dot) assisted with implementation, CPython source comparison, and review. Model version is not exposed. Validation limits are stated above.