Repository navigation
Align Template and Interpolation controls - #9709
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align Template and Interpolation controls with Python 3.15 in two native Rust files (+86/-137).
The former format_spec call resolved the inherent PyStr repr and bypassed subclass overrides. This corrects protocol dispatch; it is not presented as a demonstrated panic fix.
Validation
Compared against CPython d220409a13b77de7a6c30abe16ea90db01528edc interpolationobject.c, templateobject.c and generated Clinic binding.
58 external CPython 3.15 assertions passed, including identity/hash callback non-invocation, named arguments, validation precedence, subtype preservation, repr callbacks/errors/surrogates, temporary-result cleanup and qualified diagnostics. Independent source/lifetime review passed. Corrected type metadata matches CPython's lack of an Interpolation type text signature; new keeps the shared generic wrapper.
Threaded cargo check passed (1m29s), all-target Clippy passed (3m27s) with exactly the 12 unchanged baseline diagnostics, and normal commit hooks passed. Native RustPython execution remains unperformed because its required safety guard is not verified. No repository tests, markers, Lib files or workflows are changed; hosted runtime CI remains necessary.
Limits and integration