Repository navigation
Align Union construction and callback controls - #9714
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Share checked and unchecked construction while preserving cached partitions, hash failures, and temporary argument ownership. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__or__or__ror__.Validation
cargo checkpassed for host_env, VM and stdlib. Threaded all-targets Clippy passed with exactly the same 12 existing diagnostics as the baseline and no new warning.git diff --check, and normal commit hooks passed.Native RustPython execution is not available under the required safety guard; no native runtime or full test-suite pass is claimed. The separate non-threaded/WASM graph was not built under the current disk limit.
Integration notes
The shared dictionary hash-error formatter extraction is intentionally identical to the helper in #9693 rather than another implementation. Its set operation changes still require reconciling
add/add_known_hash: preserve #9693's hash-only contextualization, keep raw collision errors unchanged, and delegate to one raw insertion helper. The formatter also overlaps #9700's Unicode-preservingkey_hashchange: retain the extracted WTF-8 helper and #9700's other qualified-name improvements. Source composition was inspected; the combined branches have not been compiled.Union/GenericAlias representation formatting and unrelated set-operation behavior remain outside this change. Repository tests, standard-library files and workflows are unchanged.