Repository navigation
Conversation
|
Deployed adev-preview for e385635 to: https://ng-dev-previews-fw--pr-angular-angular-71773-adev-prev-gafrpb8b.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
force-pushed
the
feat/ngp-api-extraction
branch
2 times, most recently
from
November 3, 2026 20:22
3478dd0 to
2ab6aba
Compare
Decouple `DocsExtractor` from ngtsc's internal `MetadataReader` via a minimal `DocsMetadataReader` interface, and implement `getApiDocumentation` and `getApiDocumentationSync` on `HybridCompiler` in `@angular/compiler-cli/preprocessor`. Also unplug the legacy `getApiDocumentation` extraction code from `NgCompiler` and `NgtscProgram`, switch `adev`'s extraction pipeline to `HybridCompiler`, and route docs extraction specs unconditionally through the preprocessor.
JeanMeche
force-pushed
the
feat/ngp-api-extraction
branch
from
November 3, 2026 21:07
2ab6aba to
e385635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocsExtractorfromngtsc's internalMetadataReadervia a minimalDocsMetadataReaderinterface exported from@angular/compiler-cli/private/hybrid_analysis.getApiDocumentationandgetApiDocumentationSyncin@angular/compiler-cli/preprocessor(and exposes them onHybridCompiler), backed by analyzer class metadata.getApiDocumentationfromNgCompilerandNgtscProgram, and removes unusedmetadatadependency fromngtsc/docs.adev's API extraction pipeline (extract_api_to_json) to useHybridCompiler/getApiDocumentation.NgtscTestEnvironmentthrough the preprocessor, enabling all 118 docs extraction specs across both suites and removing them fromNGP_KNOWN_NGTSC_FAILURES.