Repository navigation
arch specific file OR indicator - #37
Merged
Merged
Conversation
mikeysklar
approved these changes
Oct 30, 2026
mikeysklar
left a comment
There was a problem hiding this comment.
Looks good.
Having other arch files is a waste of space.
dhalbert
requested changes
Oct 30, 2026
dhalbert
left a comment
Contributor
There was a problem hiding this comment.
How about "choose one" instead of "only need one"?
Collaborator
Author
|
@dhalbert changed to "choose one" in the latest commit. |
dhalbert
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new OR indicator when there are .mpy files for multiple arch's included in a project bundle.
This work comes out of my current project which uses turbo modules and runs on both the Fruit Jam and Metro P4. All of the Python code supports either device so the bundle will just include both compiled .mpy files. This makes an additional way to inform the user they only need to keep the one for their device.
Here are two examples:
