Repository navigation
Resolve relative $ORIGIN and $INCLUDE origins against the current origin - #432
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RFC 1035, section 5.1 states that relative names in a master file are relative to the current origin. A relative name in a $ORIGIN directive or in the origin argument of $INCLUDE was resolved against the root instead, so "$ORIGIN sub" in zone example.com. set the origin to "sub." rather than "sub.example.com.".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 1035, Section 5.1 states that a domain name that does not end in a dot is relative to the current origin.
Masterresolved the name in a$ORIGINdirective, and the optional origin of$INCLUDE, against the root instead. In zoneexample.com.,$ORIGIN subset the origin tosub.instead ofsub.example.com., so every following relative owner name ended up outside the zone. BIND and other zone file parsers append the current origin in this case.Masternow resolves both names against the current origin. If no origin is set, it falls back to the root as before. Absolute names are unchanged.Tests
MasterTest.relativeOriginDirectiveandMasterTest.relativeIncludeOrigin. Both fail on master withexpected: a.sub.example.com. but was: a.sub..mvn verifypasses, except forResolverTest.resolverListenerExceptionUnwrap, which also fails on master in the same environment (timeout).Fixes #431