⚡ Sangsakala Proxy 🏠 Home
Skip to content

feat: Add feature view versioning support to PostgreSQL and MySQL online stores #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 9 commits into from
Apr 7, 2026
Merged

feat: Add feature view versioning support to PostgreSQL and MySQL online stores #6193

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd35805
feat: Add feature view versioning support to PostgreSQL and MySQL onl…
YassinNouh21 Mar 29, 2026
5426d9c
fix: guard optional MySQL/Postgres imports in _check_versioned_read_s…
YassinNouh21 Apr 5, 2026
4abdda3
fix: drop all versioned tables on teardown and extract shared _table_id
YassinNouh21 Apr 5, 2026
0ffa1ec
style: fix ruff formatting for _table_id signatures
YassinNouh21 Apr 5, 2026
8bf0ef7
style: collapse remaining multi-line signatures to single line
YassinNouh21 Apr 5, 2026
d827045
fix: use regex for precise version table matching in teardown
YassinNouh21 Apr 5, 2026
386d01a
style: wrap long _drop_all_version_tables signature
YassinNouh21 Apr 5, 2026
e782090
fix: remove redundant DROP INDEX in MySQL _drop_table_and_index
YassinNouh21 Apr 7, 2026
47b1f36
Merge branch 'master' into feat/postgres-mysql-versioning
YassinNouh21 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use regex for precise version table matching in teardown 
LIKE _v% could match unrelated tables (e.g. driver_verbose when
dropping versions for driver). Switch to REGEXP/~ with _v[0-9]+$
pattern. Also scope Postgres pg_tables query by schemaname.

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
  • Loading branch information
@YassinNouh21 @ntkathole
YassinNouh21 authored and ntkathole committed Apr 6, 2026
commit d827045fa0259f4f7fcaca697dc96c1805e60e7e
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/online_stores/mysql_online_store/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ def _drop_all_version_tables(cur: Cursor, project: str, table: FeatureView) -> N
base = f"{project}_{table.name}"
cur.execute(
"SELECT table_name FROM information_schema.tables "
"WHERE table_schema = DATABASE() AND (table_name = %s OR table_name LIKE %s)",
(base, f"{base}_v%"),
"WHERE table_schema = DATABASE() AND (table_name = %s OR table_name REGEXP %s)",
(base, f"^{base}_v[0-9]+$"),
)
for (name,) in cur.fetchall():
cur.execute(f"DROP INDEX IF EXISTS {name}_ek ON {name};")
Expand Down
24 changes: 15 additions & 9 deletions sdk/python/feast/infra/online_stores/postgres_online_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def update(
versioning = config.registry.enable_online_feature_view_versioning
for table in tables_to_delete:
if versioning:
_drop_all_version_tables(cur, project, table)
_drop_all_version_tables(cur, project, table, schema_name)
else:
table_name = _table_id(project, table)
cur.execute(_drop_table_and_index(table_name))
Expand Down Expand Up @@ -387,12 +387,13 @@ def teardown(
entities: Sequence[Entity],
):
project = config.project
schema_name = config.online_store.db_schema or config.online_store.user
versioning = config.registry.enable_online_feature_view_versioning
try:
with self._get_conn(config) as conn, conn.cursor() as cur:
for table in tables:
if versioning:
_drop_all_version_tables(cur, project, table)
_drop_all_version_tables(cur, project, table, schema_name)
else:
table_name = _table_id(project, table)
cur.execute(_drop_table_and_index(table_name))
Expand Down Expand Up @@ -844,14 +845,19 @@ def _drop_table_and_index(table_name):
)


def _drop_all_version_tables(cur, project: str, table: FeatureView) -> None:
def _drop_all_version_tables(cur, project: str, table: FeatureView, schema_name: Optional[str] = None) -> None:
"""Drop the base table and all versioned tables (e.g. _v1, _v2, ...)."""
base = f"{project}_{table.name}"
cur.execute(
sql.SQL(
"SELECT tablename FROM pg_tables WHERE tablename = %s OR tablename LIKE %s"
),
(base, f"{base}_v%"),
)
if schema_name:
cur.execute(
"SELECT tablename FROM pg_tables "
"WHERE schemaname = %s AND (tablename = %s OR tablename ~ %s)",
(schema_name, base, f"^{base}_v[0-9]+$"),
)
else:
cur.execute(
"SELECT tablename FROM pg_tables WHERE tablename = %s OR tablename ~ %s",
(base, f"^{base}_v[0-9]+$"),
)
for (name,) in cur.fetchall():
cur.execute(_drop_table_and_index(name))