Repository navigation
fix: add watch verb on clusterroles and clusterrolebindings for feast-operator - #7062
ryder777777 wants to merge 1 commit into
Conversation
patelchaitany
left a comment
There was a problem hiding this comment.
Looks good to me.
Just something to keep in mind: watch on clusterroles and clusterrolebindings was removed in #6736 as part of narrowing the RBAC permissions. It may have been an oversight given the cached client's requirements, but I'm not sure whether that removal was intentional.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7062 +/- ##
=======================================
Coverage 51.01% 51.01%
=======================================
Files 455 455
Lines 57015 57015
Branches 8327 8327
=======================================
Hits 29089 29089
Misses 25939 25939
Partials 1987 1987
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…-operator Signed-off-by: ryder777777 <sahilridder@gmail.com>
774564c to
f38a451
Compare
What this PR does / why we need it:
controller-runtime's default cached client starts informers (List+Watch) the first timeGet/Listis called on a resource type. Currently, the Feast Operator'smanager-roleClusterRolegrantsgetandlistonclusterrolesandclusterrolebindingsinrbac.authorization.k8s.io, but omitswatch, causing the informer reflectors to fail withFailed to watch *v1.ClusterRole: ... cannot watch resource "clusterroles"andFailed to watch *v1.ClusterRoleBinding: ... cannot watch resource "clusterrolebindings".This PR adds the
watchverb toclusterrolesandclusterrolebindingsinfeaturestore_controller.go's kubebuilder RBAC markers and synced manifests (config/rbac/role.yaml,dist/install.yaml, andbundle/manifests/feast-operator.clusterserviceversion.yaml).Which issue(s) this PR fixes:
Fixes #7061
Checks
git commit -s)Testing Strategy