Repository navigation
fix: Pin build dependencies of source builds to the CI lock - #7104
Open
patelchaitany wants to merge 1 commit into
Open
patelchaitany wants to merge 1 commit into
patelchaitany wants to merge 1 commit into
Conversation
sqlglotc has no Python 3.10 wheels on PyPI, so on 3.10 uv builds sqlglotc==30.21.0 from source. Its build pulls the newest unpinned sqlglot, whose Schema class is no longer a mypyc trait, and mypyc fails with "Multiple inheritance is not supported (except for traits)". Pass the CI lock as --build-constraints so source builds use the locked versions (sqlglot==30.21.0) instead of the newest release. Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7104 +/- ##
=======================================
Coverage 51.28% 51.28%
=======================================
Files 458 458
Lines 57409 57409
Branches 8415 8415
=======================================
+ Hits 29443 29444 +1
Misses 25957 25957
+ Partials 2009 2008 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This was referenced Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
unit-test-python (3.10, ubuntu-latest)job fails on master and on every open PR since Nov 2:Cause:
sqlglotcno longer has Python 3.10 wheels on PyPI, so on 3.10uv pip syncbuildssqlglotc==30.21.0from source.sqlglot, and itssetup.pycompiles that installed copy. So the build compiles the newestsqlglotinstead of the locked 30.21.0.sqlglot,Schemais no longer a mypyc trait, soMappingSchema(AbstractMappingSchema, Schema)fails to compile.Fix: pass the CI lock as
--build-constraintsininstall-python-dependencies-ci. Source builds then use the locked versions (sqlglot==30.21.0). This only affects build-time dependencies of packages built from source; the installed set is unchanged. It is a stopgap until Python 3.10 support is dropped.Which issue(s) this PR fixes:
CI failure on Python 3.10 (no issue filed).
Checks
git commit -s)Testing Strategy
Misc
Verification is the
unit-test-python (3.10, ubuntu-latest)job on this PR; it could not be reproduced locally (no Python 3.10 available).