Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a copyright header and updates the TokenHandler to set this.tokenOptions.iss to credentials.clientEmail if it is not already defined, along with corresponding unit tests. The review feedback suggests using the nullish coalescing operator (??) instead of the logical OR operator (||) to prevent overriding valid falsy values like an empty string.
feywind
marked this pull request as ready for review
November 3, 2026 19:53
feywind
force-pushed
the
cleanup/gh9469-gtoken-keyfile-iss
branch
from
November 3, 2026 20:01
1841bc3 to
ce9967b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the cleanup.
Description
Sets
tokenOptions.issfromkeyFileclient_emailwhen fetching GoogleToken credentials.Impact
Fixes
invalid_granttoken errors when authenticatingGoogleTokenusing akeyFile.Changes
this.tokenOptions.iss = this.tokenOptions.iss || credentials.clientEmailinTokenHandler.processCredentials()when loading credentials fromkeyFile.test.tokenHandler.tsverifyingissis populated fromkeyFileand existingissvalues are preserved.Testing
core/packages/google-auth-library-nodejs/test/gtoken/test.tokenHandler.ts.Alternatives
TokenHandler.processCredentials()unchanged would continue causingGoogleTokeninstances configured withkeyFile(without an explicitissoremail) to omit theissclaim in signed JWT assertions.Fixes #9469