Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (3 classes)
|
bbakerman
approved these changes
Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change — targeted for GraphQL Java 27. Do not backport to 26.x or earlier.
Use
ExhaustedDataLoaderDispatchStrategyinstead ofPerLevelDataLoaderDispatchStrategywhen automatic dispatching is enabled and no strategy is configured. Exhausted dispatching runs queued loads when the tracked fetching/completion work and batch loading are exhausted, and supports chained loads without an opt-in.Compatibility and migration
Dispatch timing and batch composition can change: batches are no longer tied to query levels.
Obtain loaders through
DataFetchingEnvironment.getDataLoader(...). The default now returns the tracking wrapper; loading directly through the registry or a separately held loader bypasses tracking and can leave requests waiting indefinitely.To retain per-level dispatching for a request:
Existing
enableDataLoaderChaining(true)continues to select per-level chained dispatching when exhausted dispatching is unset. Explicitly enabling both strategies still fails. Disabling automatic dispatch and requests without a supplied registry still use the no-op strategy.Implementation and tests
Update strategy selection, loader wrapping, the configuration getter, and Javadoc together. Add selection coverage for queries, mutations, and subscriptions; verify the effective configuration on context builders and contexts, default chained loading, loader wrapping, and the explicit per-level migration path. Migrate the hanging-test fixture to tracked loader access and test it with both strategies. Update the deferred batching assertion to account for the new default's timing.
Validation:
./gradlew --no-daemon test testng jacocoTestReport javadocpassed on Java 25. No per-class coverage regressions againsttest-baseline.jsonusing the CI comparison rules.