Repository navigation
feat: add toSorted() explanation and examples. - #3963
Open
AlexNT-maker wants to merge 2 commits into
Open
AlexNT-maker wants to merge 2 commits into
AlexNT-maker wants to merge 2 commits into
Conversation
- Briefly explains the concept of immutability and why mutating original data is avoided in modern JS. - Introduce` toSorted()` as the modern alternative to `sort()` . - Includes a runnable code block (`js run`) demonstrating how the original array remains untouched compared to the new sorted array.
|
|
AKzar1el
reviewed
Nov 3, 2026
AKzar1el
left a comment
There was a problem hiding this comment.
One accuracy issue in the new explanation, noted inline.
|
|
||
| ### toSorted | ||
|
|
||
| In modern JavaScript, we generally avoid mutating original data, as it can lead to unexpected side effects and bugs. Because the traditional `sort()` method modifies the array in place, a new modern method was introduced. The `toSorted()` method elegantly solves this problem by returning a completely new, sorted array, leaving the initial data safely intact. It is also more optimized than the older workaround of manually cloning the array before sorting. |
There was a problem hiding this comment.
The claim that toSorted() is “more optimized” than copying and sorting isn't guaranteed. MDN describes it as the copying version of sort(), whose complexity depends on the implementation; readers may mistake this for a performance guarantee over [...arr].sort(). Could we remove the performance claim and keep the clear non-mutating behavior explanation?
Author
There was a problem hiding this comment.
Done! Thanks for the review! I have removed the performance claim in the latest commit.
Removed mention of manual cloning in toSorted method explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toSorted()as the modern alternative tosort().js run) demonstrating how the original array remains untouched compared to the new sorted array.