Repository navigation
Name refined call results after the method, as the other generated values - #483
Merged
Merged
Conversation
…lues The result of a call to a method with a contract was named #<method>_N and shown as getUndoManager⁵⁵⁵, like a program variable. It is now a generated name, #getUndoManager_result⁵⁵⁵, as the results of the calls inside an expression already were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #477 (refs #373).
Problem
The result of a call to a method with a contract was still named
#<method>_N, so messages showed it like a program variable:undoManager⁵⁵⁷ == getUndoManager⁵⁵⁵. All other generated values got descriptive names in #477.Change
MethodsFunctionsCheckernames those results withGeneratedNames.valueOf, like the other generated values:#<method>_result, and#new_<Class>for a refined constructor.EditCommand.java:69undoManager⁵⁵⁷ == getUndoManager⁵⁵⁵undoManager⁵⁵⁷ == #getUndoManager_result⁵⁵⁵AccessKeyGenerator.java:17dceSecurityNameRandom(randomUUID³⁸¹)dceSecurityNameRandom(#randomUUID_result³⁸¹)Checked on the four
exercises-ossstudy workspaces: only generated names change; no error appears, disappears or moves. Nothing depends on the old format: state checks compare the stored return-variable name, hints use method names, and the simplification and counterexample code check only the##prefix.Tests
TestGeneratedNames: the three condition messages now read#ready_resultinstead ofready.🤖 Generated with Claude Code