⚡ Sangsakala Proxy 🏠 Home
Skip to content

chore: Update dependencies and configure Dependabot for monthly updates - #360

Closed
Kumar Aditya (kumaraditya303) wants to merge 0 commit into
microsoft:masterfrom
kumaraditya303:master
Closed

Kumar Aditya (kumaraditya303) wants to merge 0 commit into
microsoft:masterfrom
kumaraditya303:master

Conversation

@kumaraditya303

@kumaraditya303 Kumar Aditya (kumaraditya303) commented Dec 10, 2020 •

Copy link
Copy Markdown
Contributor

Update dependencies and configure dependabot for monthly updates.

@mxschmitt

Copy link
Copy Markdown
Contributor

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

@kumaraditya303

Kumar Aditya (kumaraditya303) commented Dec 10, 2020 •

Copy link
Copy Markdown
Contributor Author

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

Max Schmitt (@mxschmitt) optimize images means that the images are compressed and their dimensions are untouched

@mxschmitt

Copy link
Copy Markdown
Contributor

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

Max Schmitt (@mxschmitt) optimize images means that the images are compressed and their dimensions are untouched

It wouldn't bring any benefit in terms of performance or speed for new developers since we are using Git and the images are already in the tree like that. So the git clone would also take longer since new unknown binary files got added.

@kumaraditya303

Kumar Aditya (kumaraditya303) commented Dec 10, 2020 •

Copy link
Copy Markdown
Contributor Author

Max Schmitt (@mxschmitt) Dependabot is now configured for monthly updates

@kumaraditya303 Kumar Aditya (kumaraditya303) changed the title chore: Update dependencies and Optimize Images chore: Update dependencies and configure Dependabot for monthly updates Dec 10, 2020
@pavelfeldman

Copy link
Copy Markdown
Member

Does this fix any bugs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants