Repository navigation
Conversation
Cache each valid header name with its lowercased form and the last valid string value set for it, so repeated names and values skip validation and toLowerCase() in setHeader() and appendHeader(). Arrays are always re-validated. The cache is bounded. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> Assisted-by: Claude
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67232 +/- ##
==========================================
+ Coverage 90.67% 90.70% +0.03%
==========================================
Files 797 797
Lines 278773 278935 +162
Branches 53607 53647 +40
==========================================
+ Hits 252778 253018 +240
+ Misses 16356 16258 -98
- Partials 9639 9659 +20
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setHeader()andappendHeader()validate, lowercase, and scan the value of every header on every call, even though applications send the same names and mostly the same values on every response.This caches each valid header name with its lowercased form and the last valid string value set for it, so repeated names skip the token check and
toLowerCase(), and repeated values skip the character scan. Arrays are always re-validated since they are mutable. The cache is capped at 256 names, and values longer than 256 characters are not cached.Adds
benchmark/http/set-header-rest.jsand a regression test.