Repository navigation
deps: backport libuv TTY hangup fix - #67237
Open
alexforster wants to merge 1 commit into
Open
alexforster wants to merge 1 commit into
alexforster wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
PTY output can be truncated when a hangup arrives before all buffered data has been read. I ran into this while using a terminal emulator library. Asking for a small, targeted backport of this upstream libuv fix to read the remaining data before EOF. Refs: libuv/libuv#5165 Signed-off-by: Alex Forster <alex@alexforster.com>
alexforster
force-pushed
the
deps-backport-libuv-pty-hangup
branch
from
November 4, 2026 03:48
18cf537 to
6bbf8e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTY output can be truncated when a hangup arrives before all buffered data has been read. I ran into this while using a terminal emulator library.
Asking for a small, targeted backport of this upstream libuv fix to read the remaining data before EOF.
Refs: libuv/libuv#5165
Signed-off-by: Alex Forster alex@alexforster.com