write only relative path in 'RECORD' - #3448

hum, I don't think I can figure out the missing pieces for 2.6 and pypy.

I'm guessing your change meant that the uninstall couldn't find the 2 files noted in the test, and so they didn't get uninstalled. Not sure why 2.6/PyPy would be the only ones with that behaviour...

Sorry - to be clearer, you wrote something different in RECORD which is where uninstall looks to work out what to remove.

trying to simplify to one line, seems to do the trick

my first pypy !

Note that the RECORD file (paths) should follow these semantics, as defined in PEP 376.

the file's path

• a '/'-separated path, relative to the base location, if the file is under the base location.
• a '/'-separated path, relative to the base location, if the file is under the installation prefix AND if the base location is a subpath of the installation prefix.
• an absolute path, using the local platform separator

@Ivoz I'm pretty sure that's what normpath sorts out. Although it looks like it might get it wrong if it has to fall back to an absolute path (it uses / rather than the local path separator in that case) but that's not the fault of this patch.

OTOH, there doesn't seem to be any sort of check for the condition "if the file is under the installation prefix AND if the base location is a subpath of the installation prefix" in normpath, so blindly applying normpath might be wrong (both here and for the installed files...)

The installed files have always used normpath though, and the tests all succeed, so I'm inclined to say that it's probably OK. If someone wants to add extra "torture tests" checking weird combinations where the base location is not a subpath of the installation prefix, I'd be fine with that - and if that reveals bugs then we can fix them. But I'm inclined to consider that as a separate piece of work.

I'm willing to merge this unless anyone has any objections - @Ivoz are you OK with it given my comments above?

Since installed and changed files currently go through normpath, it would make sense for generated files to do the same.

Thanks for the contribution @stonebig !

super !