Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
Author
|
@barneygale hey pls check my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-161241
Path.copy() on Linux tries FICLONE first. On filesystems where that ioctl is blocked it returns EPERM, and pathlib/_os.py copyfileobj only fell back on EBADF, EOPNOTSUPP, ETXTBSY, EXDEV, so the copy failed with PermissionError even though a regular copy works — shutil.copy() succeeds on the same files.
This adds EPERM to the _ficlone fallback list, so a blocked reflink falls through to copy_file_range / sendfile / plain read-write copying.
Tests: added CopyFileobjFallbackTest.test_ficlone_eperm_falls_back in Lib/test/test_pathlib/test_copy.py; it fails without this change and passes with it. test_pathlib.test_copy passes (53 tests).