Repository navigation
gh-161289: Respect fillvalue length when truncating in reprlib.Repr - #161290
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
…Repr repr_str(), repr_int() and repr_instance() computed how many characters to keep around the fill value assuming it is always three characters long (the default '...'). With a custom Repr.fillvalue of another length, the result exceeded or fell short of maxstring, maxlong and maxother. Use len(self.fillvalue) instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repr.repr_str(),Repr.repr_int()andRepr.repr_instance()assumed the fill value is three characters long (the default'...') when deciding how many characters to keep around it. With a customRepr.fillvalueof another length, the truncated result exceeded or fell short ofmaxstring,maxlongandmaxother. This useslen(self.fillvalue)instead. Output with the default fill value is unchanged.The new test checks the exact truncated output of a string, an int and an object for a 1-character and a 6-character fill value; it fails without the fix.
🤖 Generated with Claude Code
reprlib.Reprtruncation ignores the length of a customfillvalue#161289