Repository navigation
gh-161288: fix perf trampoline crash on UBSan builds - #161294
Open
NekoAsakura wants to merge 2 commits into
Open
NekoAsakura wants to merge 2 commits into
NekoAsakura wants to merge 2 commits into
Conversation
vstinner
approved these changes
Nov 4, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
I tested building Python with ./configure --with-undefined-behavior-sanitizer CC=clang LD=clang && make clean && make.
Without the fix, ./python -X perf -c pass logs a huge UBSan error and exit the process.
With the fix, ./python -X perf -c pass and ./python -X perf_jit -c pass complete successfully.
I confirm that #if __has_feature(undefined_behavior_sanitizer) test is true in C code built with clang -fsanitize=function or -fsanitize=undefined.
StanFromIreland
self-requested a review
November 4, 2026 08:06
Member
|
cpython/Lib/test/test_samply_profiler.py Lines 17 to 20 in 0d3ab6f It can probably be removed as well (I haven't checked)? |
Member
Author
|
@StanFromIreland Good catch, dropped it too. |
vstinner
enabled auto-merge (squash)
November 4, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.