Repository navigation
gh-139122: Fix the C UUID error message for badly formed hex strings - #161300
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_hex()inModules/_uuidmodule.cpasses thehexobject toPyErr_Format()with a%sconversion, which expects aconst char *. The message then shows bytes from the object header instead of the input, and reading it is undefined behavior:The pure-Python implementation raises
ValueError('badly formed hexadecimal UUID string')for the same input. The C version already uses that message for its other hex errors.This change makes the two remaining error paths in
from_hex()(more than 16 bytes, fewer than 16 bytes) raise the same message.python -m uuid -u uuid3 -n <bad namespace>then prints the documented error again.The new test
test_bad_hex_error_messageruns against both implementations. Five of its subtests fail on the C implementation without the fix.The C implementation is not released yet, so no NEWS entry is added (other follow-ups to gh-139122 use "skip news").