Repository navigation
gh-161299: Resolve Gecko profiler resources to module names - #161310
Open
makwana-akshat wants to merge 1 commit into
Open
makwana-akshat wants to merge 1 commit into
makwana-akshat wants to merge 1 commit into
Conversation
picnixz
reviewed
Nov 4, 2026
| resource_name = ( | ||
| os.path.basename(filename) if "/" in filename else filename | ||
| norm_filename = ( | ||
| filename.replace("\\", "/") if "\\" in filename else filename |
Member
There was a problem hiding this comment.
Why not just using os.path.sep for the separator in filenames? You don't need to have the if either. And it's not really a norm_filename as normalized filenames are not that.
picnixz
reviewed
Nov 4, 2026
| resource_idx = len(resource_names) | ||
| resource_name = ( | ||
| os.path.basename(filename) if "/" in filename else filename | ||
| norm_filename = ( |
Member
There was a problem hiding this comment.
I think a lot of this logic can be simplified using pathlib.Path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
module_utilstests: 4 passed using the local test runner.git diff --check: passed.Issue
Related to #161299.