You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
set object is not JSON serializable with iterable_mode=IM_ANY_ITERABLE #168
I'm not sure if/how this should be fixed...
On one hand, I realize that IM_ANY_ITERABLE (that by the way is the default for iterable_mode) suggests that it should slurp anything for which iter(X) works, but under the hood it is actually implemented as PyIter_Check(), and thus it is currently misleading.
On the other hand, I'm reluctant to effectively rectify its implementation, because that could break existing usages: doing that for example breaks three tests, this to mention one.
I will think about this, or wait for some feedback 😜
Activity
lelit commentedon Aug 23, 2022
Thank you for the report, I will try to understand and fix the issue.
lelit commentedon Aug 23, 2022
I'm not sure if/how this should be fixed...
On one hand, I realize that
IM_ANY_ITERABLE(that by the way is the default foriterable_mode) suggests that it should slurp anything for whichiter(X)works, but under the hood it is actually implemented as PyIter_Check(), and thus it is currently misleading.On the other hand, I'm reluctant to effectively rectify its implementation, because that could break existing usages: doing that for example breaks three tests, this to mention one.
I will think about this, or wait for some feedback 😜
akhoury commentedon Nov 8, 2022
running into this issue as well
lelit commentedon Nov 8, 2022
I started hacking on this, but got distracted away, sorry. I will try to refocus, as time permits.
NothisIm commentedon May 5, 2023
hi @lelit
any updates on this? would be really cool to get this fixed 🙏
lelit commentedon May 5, 2023
No, sorry 🤦♂️
lelit commentedon Oct 16, 2026
First of all, I'm sorry this is taking so long.
I reviewed PR #246, and I'm still unsure whether that is the right move here. I'm flip/flopping between two point of views...
IM_ANY_ITERABLEis too broad: should be deprecated and replaced byIM_ANY_ITERATOR, what it really means now