⚡ Sangsakala Proxy 🏠 Home
Skip to content

ci: pin benchmark job to ubuntu-24.04 for codspeed - #1929

Merged
bdraco merged 1 commit into
masterfrom
ci/pin-benchmark-runner
Oct 31, 2026
Merged

ci: pin benchmark job to ubuntu-24.04 for codspeed#1929
bdraco merged 1 commit into
masterfrom
ci/pin-benchmark-runner

Conversation

@bdraco

@bdraco bdraco commented Oct 31, 2026

Copy link
Copy Markdown
Member

Summary

Pins the CodSpeed benchmark job to ubuntu-24.04. ubuntu-latest now resolves to Ubuntu 26.04, which CodSpeed runner 5.2.1 rejects with Unsupported system, so the job currently fails on every PR and on master.

   benchmark:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
 ...
-          mode: instrumentation
+          mode: simulation
Failure log 
Image: ubuntu-26.04
...
  https://codspeed.io     /_/          runner v5.2.1
##[warning]The 'instrumentation' runner mode is deprecated and will be removed in a future version. Please use 'simulation' instead.
##[group]Running the benchmarks
##[error]Unsupported system

Test plan

  • benchmark job passes on this PR

@codspeed

codspeed Bot commented Oct 31, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 24 untouched benchmarks

Comparing ci/pin-benchmark-runner (155bf8b) with master (f0c27b3)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (52ed9c3) during the generation of this report, so f0c27b3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@codecov

codecov Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (52ed9c3) to head (155bf8b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1929   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3913     3913           
  Branches      568      568           
=======================================
  Hits         3908     3908           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, and may keep LGPL-2.1-or-later as an OR option so GPL-2.0-only projects can keep using the library, see #1835.

By continuing with this pull request you agree that this new contribution is offered under both Apache 2.0 and LGPL-2.1-or-later, so it is covered under either outcome.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under these licenses does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@bdraco
bdraco merged commit bd107c6 into master Oct 31, 2026
37 checks passed
@bdraco
bdraco deleted the ci/pin-benchmark-runner branch October 31, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco