⚡ Sangsakala Proxy 🏠 Home
Skip to content

improvement(ci): partition extension acceptance by fixture lifecycle - #9643

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-extension-partition-ready
Nov 3, 2026
Merged

improvement(ci): partition extension acceptance by fixture lifecycle#9643
waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-extension-partition-ready

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Run extension navigation and composer acceptance in parallel, keeping each fixture lifecycle together and preserving access coverage.
  • Bootstrap composer with its own real session and fixtures; preserve every existing behavior callback, screenshot and assertion.
  • Retain complete/native entry points and verify all three CI groups through real Git/Turbo attribution.

Type of Change

  • Performance improvement

Testing

  • Root bun run test, lint, type-check, all audits, artifact generators and block-registry check.
  • All 27 existing behavior callback bodies have identical normalized ASTs; graph attribution failed before the split and passes afterward.
  • Fresh composer E2E: 10 passed, one existing live-provider skip, 15 screenshots and zero browser errors. Navigation/access require the hosted PR acceptance jobs.
  • actionlint, ShellCheck, Bash syntax, cleanup and test-audit.
  • Splitting fixtures intentionally adds one cleanup result. Hosted timings will establish the actual wall-time effect.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 3, 2026 11:04pm UTC

Request Review

@waleedlatif1

waleedlatif1 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the latest documentation change matches the implemented split.

Summary

Splits browser extension acceptance into navigation, composer, and access jobs.

  • Extension checks now run in separate navigation, composer, and access jobs.

No new actionable issues or repository-rule violations were found.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Task["ci:e2e-browser-extension"] --> Navigation["Navigation job"]
  Task --> Composer["Composer job"]
  Task --> Access["Access job"]
  Navigation --> N["Own app, database, browser profile, and report"]
  Composer --> C["Own app, database, browser profile, and report"]
  Access --> A["Own app, database, browser profile, and report"]
Loading

Reviews (2) · Last reviewed commit: "docs(ci): describe the three extension a..." · Reviewed by Greptile

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 3, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/ci-suites.json Resolved
@waleedlatif1

waleedlatif1 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 3, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 18d12ad into staging Nov 3, 2026
82 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-extension-partition-ready branch November 3, 2026 23:13
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1