⚡ Sangsakala Proxy 🏠 Home
Skip to content

fix(extension): preserve capture focus and Sim Link routes - #9665

Merged
waleedlatif1 merged 5 commits into
stagingfrom
codex/chat-release-review-9660
Nov 4, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
codex/chat-release-review-9660

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Allow selected read-only text in focused custom elements while retaining editable-field, iframe, and closed-shadow protections.
  • Restore the initiating composer textarea after deferred page capture, including mouse sends that preserve a denied draft.
  • Decode organization bookmark names once before validation and resolution, and restore mixed-case /Sim homepage aliases without intercepting canonical /sim.

Type of Change

  • Bug fix

Testing

Four regressions were added first and reproduced against the unfixed code in CI: packaged Chrome custom-element capture, real mouse-send focus, punctuated organization bookmarks, and legacy homepage redirects. Reports are retained in packaged extension CI and application CI.

Independent source and test-audit reviews passed. Scoped formatting and diff checks passed locally; full checks and browser/HTTP acceptance run in CI. Final head 8463e683 passed application CI and packaged extension CI: 55 successful checks and 26 intentional skips. Packaged transport: 32 passed; navigation: 9; composer: 16 plus one optional live-provider skip; access: 16; Sim Links HTTP: 17; SEO HTTP: 20. Browser reports contain zero errors. Composer denial coverage retains both keyboard and mouse sends in workspace and organization chat, including real typing after focus restoration. Greptile and Cubic both report 5/5 on this head. The optional provider skip is not live-provider acceptance.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 4, 2026 10:20am UTC

Request Review

@waleedlatif1
waleedlatif1 force-pushed the codex/chat-release-review-9660 branch from 4e3185a to f68560f Compare November 4, 2026 09:44
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no outstanding findings.

Summary

The PR fixes selected-text capture, restores composer focus after deferred capture, and repairs Sim Link routes.

  • The extension can capture selected text inside a focused, read-only element.
  • Deferred sends return focus to the textarea that started them.
  • Organization bookmarks now resolve names with encoded punctuation.
  • Mixed-case /Sim paths now lead to the homepage.

Reviews (6) · Last reviewed commit: "test(extension): retain denied keyboard ..." · Reviewed by Greptile

Comment thread apps/extension/scripts/test-e2e.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile Please review current head f68560f, which includes the production fixes. The completed review inspected the superseded test-only baseline 4e3185a.

@waleedlatif1
waleedlatif1 force-pushed the codex/chat-release-review-9660 branch from f68560f to 87f475a Compare November 4, 2026 10:00
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the codex/chat-release-review-9660 branch from 550fb2b to 8463e68 Compare November 4, 2026 10:19
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5e57170 into staging Nov 4, 2026
82 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 8463e683 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant