Repository navigation
fix(extension): preserve capture focus and Sim Link routes - #9665
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4e3185a to
f68560f
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
[Medium impact] The PR appears safe to merge, with no outstanding findings. SummaryThe PR fixes selected-text capture, restores composer focus after deferred capture, and repairs Sim Link routes.
Reviews (6) · Last reviewed commit: "test(extension): retain denied keyboard ..." · Reviewed by Greptile |
f68560f to
87f475a
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
550fb2b to
8463e68
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
/Simhomepage aliases without intercepting canonical/sim.Type of Change
Testing
Four regressions were added first and reproduced against the unfixed code in CI: packaged Chrome custom-element capture, real mouse-send focus, punctuated organization bookmarks, and legacy homepage redirects. Reports are retained in packaged extension CI and application CI.
Independent source and test-audit reviews passed. Scoped formatting and diff checks passed locally; full checks and browser/HTTP acceptance run in CI. Final head
8463e683passed application CI and packaged extension CI: 55 successful checks and 26 intentional skips. Packaged transport: 32 passed; navigation: 9; composer: 16 plus one optional live-provider skip; access: 16; Sim Links HTTP: 17; SEO HTTP: 20. Browser reports contain zero errors. Composer denial coverage retains both keyboard and mouse sends in workspace and organization chat, including real typing after focus restoration. Greptile and Cubic both report 5/5 on this head. The optional provider skip is not live-provider acceptance.Checklist
test-auditauthoring gate)