Repository navigation
Conversation
Since SQLite 3.44.0 (check-in af527231c, 2023-10-13) a CREATE TABLE whose generated columns depend on each other fails at once; before, the table was created and the loop surfaced on first use, which is the only place SQLite3Provider.checkTablesForGeneratedColumnLoops expects it. Generated columns are on by default since upstream sqlancer#1238 (2025-06), so the table generator could hit an AssertionError on any current sqlite-jdbc: the 2026-10-05 trunk run lost a thread to it. The new test fails without the change on that run's statement. Co-Authored-By: Claude Code <noreply@anthropic.com>
Author
|
CI note: the three failing jobs (Citus, Presto, TiDB QPG) are pre-existing flakiness unrelated to this PR — the same jobs fail on I merged the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1369.
A
CREATE TABLEwhose generated columns depend on each other has failed immediately withgenerated column loop on "..."since SQLite 3.44.0 (check-in af527231c), butSQLite3TableGenerator.createTableStatementdid not list that message among its expected errors, so SQLancer raised an AssertionError and lost the thread — a false alarm on SQLancer's side.This PR:
generated column loopto the expected errors ofcreateTableStatement;SQLite3Provider.checkTablesForGeneratedColumnLoopsfor pre-3.44 SQLite, where the table is created and the loop only surfaces on first use;TestSQLite3GeneratedColumnLoop, which replays the statement from the 2026-10-05 run that triggered this; the test fails without the fix and passes with it.@mrigger as discussed in the issue.
🤖 Generated with Claude Code