⚡ Sangsakala Proxy 🏠 Home
Skip to content

fix: broken grammar of LIKELIHOOD - #650

Merged
bajinsheng merged 1 commit into
sqlancer:masterfrom
bajinsheng:master
Dec 17, 2022
Merged

bajinsheng merged 1 commit into
sqlancer:masterfrom
bajinsheng:master

Conversation

@bajinsheng

Copy link
Copy Markdown
Collaborator

To avoid the grammar error: The second argument of LIKELIHOOD must be a float number within 0.0 -1.0

@bajinsheng
bajinsheng requested a review from mrigger December 17, 2022 09:42
@bajinsheng bajinsheng linked an issue Dec 17, 2022 that may be closed by this pull request
@bajinsheng
bajinsheng enabled auto-merge (squash) December 17, 2022 09:42
@bajinsheng

Copy link
Copy Markdown
Collaborator Author

This fix works for SQLite >=3.6.0

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume with this change, we can also remove the corresponding expected error below?

errors.add("second argument to likelihood() must be a constant between 0.0 and 1.0");

@bajinsheng

Copy link
Copy Markdown
Collaborator Author

Oh yes. Didn't notice that.

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bajinsheng
bajinsheng merged commit ca70c6a into sqlancer:master Dec 17, 2022
albertZhangTJ pushed a commit to albertZhangTJ/sqlancer-lancerfuzz that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support QPG

2 participants