Repository navigation
opt: support new features in SQLite - #654
Merged
Merged
Conversation
bajinsheng
enabled auto-merge (squash)
December 17, 2022 13:48
mrigger
reviewed
Dec 17, 2022
| public boolean executeQuery = true; | ||
|
|
||
| @Parameter(names = { | ||
| "--max-tables" }, description = "The maximum number of tables/virtual tables/ rtree tables/ views that can be created") |
Contributor
There was a problem hiding this comment.
Could we use --max-num-tables here and --max-num-indexes below, to match the naming convention of other option classes (see below)?
|
|
||
| @Parameter(names = { | ||
| "--max-tables" }, description = "The maximum number of tables/virtual tables/ rtree tables/ views that can be created") | ||
| public int maxTable = 10; |
| public int maxTable = 10; | ||
|
|
||
| @Parameter(names = { "--max-index" }, description = "The maximum number of indexes that can be created") | ||
| public int maxIndex = 20; |
Closed
mrigger
reviewed
Dec 18, 2022
| REINDEX(SQLite3ReindexGenerator::executeReindex), // | ||
| ANALYZE(SQLite3AnalyzeGenerator::generateAnalyze), // | ||
| DELETE(SQLite3DeleteGenerator::deleteContent), // | ||
| PRAGMA(SQLite3PragmaGenerator::insertPragma), // 0 |
Contributor
There was a problem hiding this comment.
Not sure why we are numbering the actions here?
Collaborator
Author
There was a problem hiding this comment.
I number these actions for debugging. The enumeration variable only includes index information in execution, and these numbers help me to quickly locate which action is selected and executed.
albertZhangTJ
pushed a commit
to albertZhangTJ/sqlancer-lancerfuzz
that referenced
this pull request
Dec 19, 2022
* opt: support maximum number of table/index * opt: support explain interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new features are required for QPG in SQLite.