Repository navigation
fix: switch off vectorize cockroachdb - #659
Merged
Merged
Conversation
mrigger
reviewed
Dec 18, 2022
mrigger
left a comment
Contributor
There was a problem hiding this comment.
Since vectorization is on by default, perhaps we can just remove the option to make vectorization more likely and the code here?
Contributor
|
https://github.com/sqlancer/sqlancer/blob/master/src/sqlancer/cockroachdb/gen/CockroachDBSetSessionGenerator.java also randomly turns vectorization off. |
Collaborator
Author
So we fully remove this switch here? |
mrigger
removed their request for review
December 18, 2022 08:43
mrigger
approved these changes
Dec 18, 2022
albertZhangTJ
pushed a commit
to albertZhangTJ/sqlancer-lancerfuzz
that referenced
this pull request
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vectorize option is
onby default: https://www.cockroachlabs.com/docs/v22.2/vectorized-execution#configure-vectorized-execution so we are required to randomly switch it off here.