Repository navigation
Update CHECK constraint expressions when renaming a column - #4232
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
When a column was renamed in the Edit Table dialog, the column names referenced in column and table CHECK constraint expressions were not updated. SQLite itself rewrites them during ALTER TABLE RENAME COLUMN, but the dialog's table definition still contained the old name, so alterTable() saw a difference and recreated the table with a CHECK referring to the old, no longer existing column. Table::renameKeyInAllConstraints() now also rewrites the column name in all CHECK expressions, leaving string literals, comments and function names alone. See issue sqlitebrowser#1817
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a column was renamed in the Edit Table dialog, the column names referenced in column and table CHECK constraint expressions were not updated. SQLite itself rewrites them during ALTER TABLE RENAME COLUMN, but the dialog's table definition still contained the old name, so alterTable() saw a difference and recreated the table with a CHECK referring to the old, no longer existing column.
Table::renameKeyInAllConstraints() now also rewrites the column name in all CHECK expressions, leaving string literals, comments and function names alone.
See issue #1817